NFS exports restored as read-only #2912 #2922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Includes - Instructions on fixture creation. - Instructions on running nfs export tests. - Modernise test_nfs_export.py by re-instating test_nfs.json fixture and removing prior hard-coded object mock stand-ins for DB models during these test runs.
- Add default ordering to NFSExportGroup models. Addresses re-enabled test provoked warnings re: "UnorderedObjectListWarning: Pagination may yield inconsistent results with an unordered object_list"
Resolve remaining TODOs in test_nfs_export.py. Includes: - Removing redundant tests. - Modifying previously remarked out sanity check tests to instead cover our umbrella low-level exception. Once more specific sanity checks are in place, we can add tests to prove their function.
- Black reformatting test_nfs_export.py.
- Enable previously dormant field validation via addition of: NFSExportGroup.clean_fields() prior to model.save(). Affects: host_str, modify_str, & sync_choice during post & put. - Additional tests to prove field validation function within current validation capability (need refinement).
- Additional test_post() with API / DB / Web-UI mapping info.
- nfs_export_group.py comment correction & black formatting.
- Additional NFS debug logging & comments: config_backup.py. - Some string.format to fstring updates.
|
Closing as, thus far, this work (bar some trivial dev logging & comment) has now been spun-out and merged into the following:
Putting the code base into a better state re NFS export to now approach the originally intended issue of:
where the cause for this failure is now understood and detailed within the issue referenced. A new PR will be presented, now we have the two spin-off issue/pr sets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress / save point re #2912 .
Includes
Addresses re-enabled test provoked warnings re:
"UnorderedObjectListWarning: Pagination may yield inconsistent
results with an unordered object_list"
umbrella low-level exception. Once more specific sanity checks are in place,
we can add tests to prove their function.