Rock-on install wizard obfuscates share container info #2886 #2888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure Rock-on install wizard maintains container awareness re requested Share mapping. Enabling more robust back-end Share to container volume mapping in multi-container Rock-ons.
Fixes #2886
Testing
Issue detailed multi-container reproducer Rock-on (in Draft PR) successfully mapped two different containers with the same internal volume mapping
/etc/bareos
to two different Shares:Requested Share:Volume mapping:
Resulting Share:Volume mapping:
Prior to the proposed changes, both
/etc/bareos
volume mappings from the two different containers in the reproducer Rock-on were inadvertently mapped to the last Share specified against a container volume of/etc/bareos
. As described in the linked issue.Linking to a recent (now merged) parallel fix for Rock-on
environment
elements: #2887