Disk activity widget inactive - Tumbleweed #2844 #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add filter to `/proc/diskstats` excluding block loopback major device 7. This avoids a failed byid_name lookup via byid_disk_map() as loop* block devices do not have byid names, and are not devices of interest. Includes - Additional sanity check on diskstats re ignoring < 14 columns. - Filter out SCSI CD-ROM and Floppy disks re /proc/diskstats. - Associated comment & TODO updates/additions. - Minor type hint improvement. - Updated get_byid_name_map() test data re newer kernels.
TestingTwo rpms were build on TW and Leap 15.6 (both X86_64) and both resulting installs had functional "Disk Activity" widgets on the Dashboard: Leap 15.6Test against regression as this already worked. TumbleweedPrior reproducer system for no activity in "Disk Activity" widget: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add filter to
/proc/diskstatsexcluding block loopback major device 7. This avoids a failed byid_name lookup via byid_disk_map() as loop* block devices do not have byid names, and are not devices of interest.Includes
Fixes #2844