Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub status "unknown" - Leap 15.6 OS base #2872 #2873

Conversation

phillxnet
Copy link
Member

Adopt packaging library as a direct dependency to enable more sophisticated btrfs-progs version assessment. Previously already an indirect dependency of gunicorn. Moving to explicit dependency to avoid issues re gunicorn's deprecation in the future.

Includes

  • Additional test data pertaining to Leap 15.6 and newer, re btrfs-progs version.
  • Additional test data re exception handling (fail through) re non PEP 440 compliant 'btrfs-progs version' output.

Fixes #2872

Adopt packaging library as a direct dependency to enable
more sophisticated btrfs-progs version assessment. Previously
already an indirect dependency of gunicorn. Moving to explicit
dependency to avoid issues re gunicorn's deprecation in the
future.

Includes
- Additional test data pertaining to Leap 15.6 and newer,
re btrfs-progs version.
- Additional test data re exception handling (fail throught)
re non PEP 440 compliant 'btrfs-progs version' output.
@phillxnet
Copy link
Member Author

phillxnet commented Jul 15, 2024

Testing

On an issue-reproducer system (dev machine using Leap 15.6 X86_64) we have one before (see: #2872 (comment)) and one after scrub status reports:

finished-scrub-status-leap-15 6

And we have the following imported ROOT pool in "running" scrub status:

running-scrug-ROOT-pool-leap-15 6

After a little time, and Web-UI refresh, we see this same ROOT pool scrub as having finnished:

finnished-scrub-ROOT-pool-leap-15 6

@phillxnet phillxnet marked this pull request as ready for review July 15, 2024 20:00
Copy link
Member

@FroggyFlox FroggyFlox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phillxnet for this proper fix!
I can confirm it fixes the issue in Leap 15.6 on my end too; Leap 15.5 is still working as intended as well.
All tests also pass on my Leap 15.6 VM.

@phillxnet
Copy link
Member Author

@FroggyFlox Thanks for the review & 15.5 check: much appreciated. I'll get this merged directly.

I know we have the question of need, for this legacy btrfs-progs support, as per #2872 (comment): i.e. do we really need to support pre Leap 15.4 btrfs-progs versions. But we are in very late testing here so minimal changes to address indicated issue. We also have the potential to migrate scrub to Huey (or a more Django native Huey replacement) but our consensus appears to be that this is better tackled in the next or next-plus-one testing phase.

@phillxnet
Copy link
Member Author

phillxnet commented Jul 16, 2024

An rpm was test built using this branch (Leap 15.6 X86_64 host) and looks to behave as-per the testing report so far. We also have the new dependency here which now shows up as a new top-level one re:

cd /opt/rockstor/
poetry show --tree
...
gunicorn 22.0.0 WSGI HTTP Server for UNIX
└── packaging *
...
packaging 24.1 Core utilities for Python packages
psutil 5.9.4 Cross-platform lib for process and system monitoring in Python.
...

Where-as previously we only saw the packaging dependency as secondary: i.e. via gunicorn as in the above.

@phillxnet phillxnet merged commit 185a8d0 into rockstor:testing Jul 16, 2024
@phillxnet phillxnet deleted the 2872-Scrub-status-unknown---Leap-15.6-OS-base branch July 16, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants