-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leap 15.6: SFTP share error - library paths changed #2856 #2858
Leap 15.6: SFTP share error - library paths changed #2856 #2858
Conversation
Move to dynamic discovery of bash & rsync libraries when populating ssh / sftp share chroot. Incidental dropping of the redundant chroot `bin` dir, we now use only `/usr/bin` for both the `bash`, and `rsync` binaries.
TestingAs per documented setup:
CLI client SFTP accessIndicating chroot with sftp-share mount point: Leap 15.4
Leap 15.5
Leap 15.6
Tumbleweed
|
Tree of ChrootLeap 15.4
Leap 15.5
Leap 15.6
Tumbleweed
|
Testing aarch64Leap 15.5, 15.6, TumbleweedAt (4.) we have a failure re ld-linux-aarch64.so.1
Chroot status post above error:
And ldd as per test data:
and we have:
|
We may just be failing on the /lib dir availability for aarch64 in the current PR form.
I.e. we create /lib64:
but no lib. |
To investigate the last Leap version in aarch64 that used our previously hard-coded
But we have an accompanying:
15.4 aarch64
also with an accompanying:
15.5 aarch64
Similarly:
So it seems our prior aarch64 hard coding to /lib64 worked by virtue of sourcing a link, and using that links path. Where-as ldd reports this file, which our new setup copies the path for, and tries to re-create in the same location it is found & reported by ldd, but the parent /lib location is not created. |
Ldd reports /lib for ld-linux-aarch64.so.1, this needs to exist for our chroot copy to work. Previously we sourced a link from /lib64 which we do already create.
Following on from the last patch commit here, where we now create a /lib dir in our chroot - prior to lib coping, we have a successful aarch64 result: Testing aarch64 post patchLeap 15.4
tree:
Leap 15.5
tree
Leap 15.6
with the following files:
Tumbleweed
Tree:
|
Post /lib patch for aarch64A x86_64 Leap 15.6 instance was retested with the expected empty /lib directory but all sftp access working as per pre-patch.
Tree:
|
@FroggyFlox & @Hooverdan96 |
Thank you so much @phillxnet for taking the time and effort in fixing this the right way. I should have done last time I adjusted those hard coded libs; my apologies for thinking it would be sustainable. Given your extensive (and very tedious) and thorough testing, I'm very confident it's ready to be merged in my opinion. I'm not sure when I'll be able to actually test it but after looking at the changes, it looks good to me. |
Move to dynamic discovery of bash & rsync libraries when populating ssh / sftp share chroot. Incidental dropping of the redundant chroot
bin
dir, we now use only/usr/bin
for both thebash
, andrsync
binaries.Fixes #2856
Associated development draft PR: #2857