Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.9-0 & 5.0.10-0 lsblk whitespace only values - not enough values to unpack #2853 #2855

Conversation

phillxnet
Copy link
Member

@phillxnet phillxnet commented Jun 20, 2024

VM instance report had all whitespace VENDOR value returned by lsblk. Add re.sub() pre-processor to each lsblk line prior to main parsing.

Includes

  • Remarked out (noisy) debug line to ease future investigations.
  • Additional unit-test reproducer to prove fix and guard against regression.

Fixes #2853

…o unpack rockstor#2853

VM instance report had all whitespace VENDOR value returned by lsblk.
Add re.sub() pre-processor to each lsblk line prior to main parsing.

Includes
- Remarked out (noisy) debug line to easy future investigations.
- Additional unit-test reproducer to prove fix and guard against
regression.
@phillxnet
Copy link
Member Author

A Leap 15.6 host successfully built a test rpm 5.0.10-2855, so all tests pass, including the additional one added to prove this fix.

@phillxnet phillxnet merged commit 0f70e46 into rockstor:testing Jun 22, 2024
@phillxnet phillxnet deleted the 2853-5.0.9-0-&-5.0.10-0-lsblk-whitespace-only-values---not-enough-values-to-unpack branch June 22, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant