Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyzmq dependency to latest #2746 #2747

Merged

Conversation

phillxnet
Copy link
Member

Remove explicit pinning of pyzmq, enabling: 19.0.2 to 25.1.1 update as per poetry.lock.

Fixes #2746

Remove explicit pinning of pyzmq, enabling:
19.0.2 to 25.1.1 update as per poetry.lock.
@phillxnet
Copy link
Member Author

The 0mz library is used exclusively by our replication sub-system that is currently suffering a regression regarding our recent Django-oath-toolkit update (in current testing phase) where upstream no longer provide a method to retrieve, from DB, our cliapp secret. We are as such awaiting development on the following issues:

See: Adopt dedicated secrets management library #2728

Replication regression issue: "Replication regressions" #2748

@phillxnet
Copy link
Member Author

@FroggyFlox @Hooverdan96 we have not our first/last chicken and egg scenario. I'm unable to test this as we have outstanding breaking updates already: however we also have a pressing need to move our base Python and Django along. And this library is one of our oldest yet to be updated.

This PR does not break rpmbuild on a 15.5 amd64 of a 5.0.5-2747 RPM, which then install on the host OK, but given the above I'm then not able to test replication anyway. As such I've broken out the following issue:

#2748

To collect current replication breaking/suspected-breaking changes.

But we still have to move-along with our pending Python and Django (and Poetry) updates: all of which are intertwined, so I propose that we merge this PR to at least remove all/any blockers on those more fundamental fronts. These temporary breakages are, I think, an inevitability give our massive changes of late. But to date we have only Replication as a known casualty.

@FroggyFlox
Copy link
Member

@phillxnet , I completely agree.

Updating all of this is a requirement to fix replication anyway so we should get that in first so that we can fix it.

@phillxnet phillxnet merged commit e7edab7 into rockstor:testing Nov 16, 2023
@phillxnet phillxnet deleted the 2746-Update-pyzmq-dependency-to-latest branch November 16, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants