Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django-rest-framework to latest #2738 #2743

Conversation

phillxnet
Copy link
Member

Updates DRF from 3.13.1 to latest 3.14.0. Via removal of our now redundant Django version related pinning.

Includes

  • Incidental urllib3 update from 2.0.7 to 2.1.0.

Fixes #2738

Updates DRF from 3.13.1 to latest 3.14.0. Via removal of
our now redundant Django version related pinning.
# Includes
- Incidental urllib3 update from 2.0.7 to 2.1.0.
@phillxnet
Copy link
Member Author

phillxnet commented Nov 13, 2023

Testing

An RPM (5.0.5-2743) was successfully built and installed with this PR pre-merged. Proving all tests passed within the rpmbuild %check scriptlet environment (https://github.com/rockstor/rockstor-rpmbuild/tree/testing).

A subsequent run of all tests on the build host (15.5 amd64) resulted in:

rleap15-5:~ # cd /opt/rockstor/src/rockstor/
rleap15-5:/opt/rockstor/src/rockstor # export DJANGO_SETTINGS_MODULE=settings
rleap15-5:/opt/rockstor/src/rockstor # poetry run django-admin test -v 2
...
----------------------------------------------------------------------
Ran 278 tests in 30.712s

OK

The resulting Rockstor instance accepted initial admin user setup and pool import followed by a successful Huey task completion: data pool balance.

[13/Nov/2023 18:21:21] INFO [storageadmin.tasks:56] Now executing Huey task [start_balance], id: e794a412-f1d6-4da7-857d-d7ab2f8a4365.
[13/Nov/2023 18:21:30] INFO [storageadmin.tasks:64] Task [start_balance], id: e794a412-f1d6-4da7-857d-d7ab2f8a4365 completed OK
[13/Nov/2023 18:21:30] INFO [storageadmin.tasks:67] Updating end_time accordingly to 2023-11-13 18:21:30.385904+00:00
[13/Nov/2023 18:21:30] INFO [storageadmin.tasks:56] Now executing Huey task [update_end_time], id: 99281a62-3ce8-485b-9803-f45d3467617b.
[13/Nov/2023 18:21:30] INFO [storageadmin.tasks:64] Task [update_end_time], id: 99281a62-3ce8-485b-9803-f45d3467617b completed OK

@FroggyFlox
Copy link
Member

Thanks for all the tests, @phillxnet !
I just wanted to confirm that, as expected, the 5.0.5-2743 rpm built and installed successfully on my end as well.

@phillxnet
Copy link
Member Author

phillxnet commented Nov 14, 2023

@FroggyFlox Thanks for the confirmation. Much appreciated.
Merging this to press on with our technical dept main objective.

@phillxnet phillxnet merged commit 6b83f9f into rockstor:testing Nov 14, 2023
@phillxnet phillxnet deleted the 2738-Update-Django-rest-framework-to-latest branch November 14, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants