Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove django-braces dependency #2709 #2711

Merged

Conversation

phillxnet
Copy link
Member

Remove now defunct django-braces dependency. Likely left over from a prior requirement.

Includes

  • Incidental/unrelated update to urllib3 2.0.6 to 2.0.7.

Fixes #2709

Remove now defunct django-braces dependency. Likely
left over from a prior requirement.

## Includes
- Incidental/unrelated update to urllib3 2.0.6 to 2.0.7.
@phillxnet phillxnet marked this pull request as draft October 18, 2023 17:00
@phillxnet
Copy link
Member Author

Testing

Actually unrelated to PR as there is no known use of this library. Noting just as a quick current-state of capability.

CLI test run:

lbuildvm:~ # cd /opt/rockstor/src/rockstor/
lbuildvm:/opt/rockstor/src/rockstor # export DJANGO_SETTINGS_MODULE=settings
lbuildvm:/opt/rockstor/src/rockstor # poetry run django-admin test -v 2
...
----------------------------------------------------------------------
Ran 262 tests in 26.129s

OK

An RPM was successfully built and installed with this match pre-merged. The resulting instance was able to:

  • Initiate via the Web-UI setup.
  • Install all pending upstream base OS update.

127.0.0.1 - - [18/Oct/2023:18:18:46 +0100] "POST /api/commands/update HTTP/1.1" 200 6 "-" "python-requests/2.31.0" 120145ms

  • Import a pool.
  • Configure Rock-ons system.
  • Install and run the netdata Rock-on.
  • Stop and remove Rock-on.
  • Stop Rock-ons service.
  • Collect and present in Web-UI a drives SMART data.
  • Create share.
  • Export share via SMB.
  • Remove export.
  • Remove share.
  • Turn off SMB servcie.
  • Create scheduled task to snap.
  • Remove scheduled task.
  • Remove snapshots.
  • add new user.
  • remove new user.

@phillxnet phillxnet marked this pull request as ready for review October 18, 2023 17:37
@phillxnet
Copy link
Member Author

@FroggyFlox & @Hooverdan96 I'll pop this in as I'm pretty sure, bar the incidental urllib3 minor update, we have no actual change here. It seems this was a ghost import that I failed to appreciate until our current run on dependency re-examination/update-run!

@phillxnet phillxnet merged commit acb657c into rockstor:testing Oct 18, 2023
@phillxnet phillxnet deleted the 2709-re-asses-django-braces-requirement branch October 18, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant