Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Requests library to latest #2704 #2705

Merged

Conversation

phillxnet
Copy link
Member

Remove our prior pinning for 'requests' as no longer required.

Includes:

  • Adding 10 second timeout on update repo status check, to avoid indefinite hang potential.
  • Re Black formatting on changed pkg_mgmt.py file.

Fixes #2704

Remove our prior pinning for 'requests' as no longer required.
## Includes:
- Adding 10 second timeout on update repo status check, to
avoid indefinite hang potential.
- Re Black formatting on changed pkg_mgmt.py file.
@phillxnet
Copy link
Member Author

Testing

An RPM based install (Leap 15.5 amd64 build host) could successfully:

  • Subscribe to stable, move to testing, then move back to stable and back to testing without issue.
  • Pull in the newest list of Rock-ons, with the User-Agent of 'python-requests/2.31.0' confirmed in the rock-ons server logs.

@phillxnet phillxnet marked this pull request as ready for review October 16, 2023 10:11
@phillxnet
Copy link
Member Author

Popping this one in as per our current trend re addressing our updates backlog (technical dept). And to assist with current milestone goals.

@phillxnet phillxnet merged commit bc58e9b into rockstor:testing Oct 16, 2023
@phillxnet phillxnet deleted the 2704-Update-Requests-library-to-latest branch October 16, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant