Explicitly set REALM when querying workgroup #2671 #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During Active Directory activation, we query the Workgroup information from the AD server using `net ads workgroup`. This normally gets its parameters from `smb.conf` but we need here to explicitly give the required server information at the command call given we usually work with an empty `smb.conf` file at this stage. This commit switches from using the `-S|--server` flag to the `--realm` flag as that has proven more robust.
phillxnet
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
@FroggyFlox This is a nice find/fix: much appreciated.
This is more of a cursory review I'm afraid as I don't have a setup to test this. But merging into relatively early testing to gain more 'proper' field tests.
Thanks for the continuing work re moving us over to using Type hints & non single character variable names, & our on-going test instructions/fstring updates: again much appreciated.
|
We have a successful Tumbleweed build so tests look to be good there also: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2671
@phillxnet, @Hooverdan96, ready for review.
During Active Directory activation, we query the Workgroup information from the AD server using
net ads workgroup. This normally gets its parameters fromsmb.confbut we need here to explicitly give the required server information at the command call given we usually work with an emptysmb.conffile at this stage.This Pull request switches from using the
-S|--serverflag to the--realmflag as that has proven more robust.Functional testing
Rockstor built from this branch on Leap 15.5 can successfully activate the Active Directory service configured to connect to a Samba 4-backed AD domain controller found at
samdom.example.com.Unit testing