Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surface Distro Version to breadcrumb bar #2668 #2670

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

Hooverdan96
Copy link
Member

Fixes #2668. Instead of showing the distro version via the mouse over, this change will show it directly as part of the breadcrumb bar.

After the changes and static collection, the version now shows up alongside the distro name and kernel version:

image

A mouseover doesn't show up anymore.
Changes also survive reboots.

Not sure whether that was necessary, but in any case ran the tests:

Ran 253 tests in 40.992s

@phillxnet phillxnet added the needs review Ideally by prior rockstor-core contributor label Sep 5, 2023
@phillxnet
Copy link
Member

@Hooverdan96 Thanks for seeing to this. Much appreciated.

Copy link
Member

@phillxnet phillxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hooverdan96 Thanks for stepping up to this one. Much appreciated.

Leap15 5-uses-header

Tumbleweed-uses-header

This looks to be exactly as intended. And should help with folks reporting their base OS more easily.

@phillxnet phillxnet changed the title surface Distro Version to breadcrumb bar (2668) surface Distro Version to breadcrumb bar #2668 Sep 15, 2023
@phillxnet phillxnet merged commit 141ecad into rockstor:testing Sep 15, 2023
@Hooverdan96 Hooverdan96 deleted the 2668_distro_version branch October 16, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Ideally by prior rockstor-core contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants