Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use user.is_authenticated as an attribute #2664 #2665

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Use user.is_authenticated as an attribute #2664 #2665

merged 1 commit into from
Aug 22, 2023

Conversation

FroggyFlox
Copy link
Member

Fix #2664
@phillxnet, @Hooverdan96: ready for review

Prior to Django 1.10, user.is_authenticated() was a method. Since then, compatibility was ensured but this compatibility will be removed in Django 2.0. See #2664 for more details and background.

This Pull Request (PR) simply proposes to move to using the user.is_authenticated attribute instead.

Functional testing

Prior to this PR, fully refreshing a webpage (Ctrl + Shift + R) would show the warning described in #2664.
After this PR, this no longer appears.

Unit testing

All tests still pass:

buildvm155:/opt/rockstor # cd src/rockstor/ && poetry run django-admin test ; cd -
Creating test database for alias 'default'...
Creating test database for alias 'smart_manager'...
System check identified no issues (0 silenced).
......................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 262 tests in 14.807s

OK
Destroying test database for alias 'default'...
Destroying test database for alias 'smart_manager'...

@FroggyFlox
Use user.is_authenticated as an attribute rockstor#2664
f84771e 
Prior to Django 1.10, user.is_authenticated() was a method.
Since then, compatibility was ensured but this compatibility will be
removed in Django 2.0. This commit thus moves to using the
user.is_authenticated attribute instead.
@FroggyFlox FroggyFlox linked an issue Aug 21, 2023 that may be closed by this pull request
(t) models.User.is_authenticated() will be deprecated in Django 2.0 #2664
Closed
@FroggyFlox FroggyFlox added the needs review Ideally by prior rockstor-core contributor label Aug 21, 2023
@phillxnet
Copy link
Member

@FroggyFlox Merging on the basis of the testing provided. As you say this does look like a simple drop-in replacement.
Thanks again for yet more preparation re the current Django milestone.

@phillxnet phillxnet merged commit b4128ad into rockstor:testing Aug 22, 2023
@phillxnet phillxnet mentioned this pull request Aug 22, 2023
Closed
@FroggyFlox FroggyFlox deleted the 2664-models.User.is_authenticated()-will-be-deprecated-in-Django-2.0 branch October 20, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review Ideally by prior rockstor-core contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(t) models.User.is_authenticated() will be deprecated in Django 2.0
2 participants
@FroggyFlox @phillxnet