Improve rockstor.service re robustness #2657 #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interact better with supervisord by not overriding shutdown. - Adds ExecStop instructing supervisord accordingly. - Adds ExecReload (for completeness as unused). - systemd's charge in this service is supervisord only, limit our KillMode to 'process' accordingly. This avoids and additional 1 minute timeout during our AT update script execution. Note that we currently run supervisord in foreground mode.
|
See linked issue comments for development and testing notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interact better with supervisord by not overriding shutdown.
Note that we currently run supervisord in foreground mode.
Fixes #2657