Save network usage processed data as List object #2577 #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python2, we directly saved our processed parsing of network activity directly from `map()`. In Python3, `map()` now returns an iterator which prevents us from picking each of its included data one at a time as we used to do (this now only works once). This commit saves the `map()` object as a List so that we can extract from it as needed.
- use more explicit variable name for `line` (fixes PEP 8: E741 ambiguous variable name 'l') - Update Copyright (date + https) - Black formatting
phillxnet
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
@FroggyFlox Thanks for sorting this out, and for the detailed explanation.
Adding the list cast locally and what do you know:
Nice. Merging now directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2577
@phillxnet, ready for review
The network widget was not displaying any data due to a change in what the
map()function returns:We then pick many elements of that object to construct our "payload" to the widget. Because is is now an iterator, this worked only the first element, but then returned empty for all others, leading to an empty payload to the widget.
Saving this as a list allows us to get back to previous behavior, resulting in a functional widget:
