Enhance Pool size calculation re new raid levels #2525 #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move static elements of raid levels to our overall PROFILE var and do minor refactor of remaining size calculation code to clarify parameters involved. Improve flexibility re hard-wired chunk/stripe setting: here we sacrifice some speed for flexibility.
|
@FroggyFlox & @Hooverdan96 I'll go ahead and merge this as it looks pretty safe, plus it fixes an obvious Web-UI fail in our new raid levels. Plus we are still in testing (only just mind). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move static elements of raid levels to our overall PROFILE var and do minor refactor of remaining size calculation code to clarify parameters involved. Improve flexibility re hard-wired chunk/stripe setting: here we sacrifice some speed for flexibility.
Fixes #2525
Testing:
A 4 X 5 GB array underwent a Resize/ReRaid, via the Web-UI, so that it was, in turn, one of:
raid1c3, raid1c4, single, raid0, raid1, raid10, raid5, & raid6.
All Pool size reports within the Web-UI, post integrated balance completion and Web-UI refresh, were consistent with identical geometries entered into:
https://carfax.org.uk/btrfs-usage/