drop qgroupid in share create when quotas are disabled #2506 #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we passed our -1/-1 'quotas disabled' flag value to btrfs subvol create and it was silently ignored. This no longer works: resulting in an error: 'invalid qgroupid ...'. So drop the use of '-i qgroupid' when our flag value is found. Includes updated docstrings for the altered code. Also includes contextual fix re typo in two log entries that advice on quota indeterminate remedial action: "btrfs qgroup disable" corrected to "btrfs quota disable"
TestingNo tests were added or altered and we have the following result form our current test set:
Functional testing via Web-UI:A pool was set quotas disabled and a share was created successfully, previous to this proposed patch the issue was evident. Quotas were re-enabled and our prior behaviour of Rockstor native (2015/n) qgroup assignment was performed when subsequent shares were created. |
This was referenced Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we passed our -1/-1 'quotas disabled' flag value to btrfs subvol create and it was silently ignored. This no longer works: resulting in an error: 'invalid qgroupid ...'. So drop the use of '-i qgroupid' when our flag value is found. Includes updated docstrings for the altered code.
Fixes #2506
Also includes contextual fix re typo in two log entries that advice on quota indeterminate remedial action:
"btrfs qgroup disable" corrected to "btrfs quota disable"
Fixes #2509