Remove raid0 dev restriction & tidy pool dev fencing code #2385 #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously blocked raid0 disk removal outright. Move to allowing device removal, as per all other profiles, within profile limits. Abstract btrfs-raid profile minimum device count & maximum device missing info and use the former through-out the fencing code. Adapt all related tests to the newly uniform error messages that result from hitting the remaining revised limitations. These code changes are also intended to ease our adoption of raid1c3 & raid1c4 profiles. And form the initial awareness of these newer btrfs-raid profiles.
|
While working on #2394 I have need for a structure created in this pull request. As we are in testing still (although mid RC phase) I think we are OK to merge this as-is. I do see a comment typo but I may end up moving the associated new structure in my current issue anyway, so can sort the typo in the process. I'll leave merging for a little longer in case anyone is mid review. |
|
@phillxnet , |
|
@FroggyFlox Thanks, and no worries. Cheers for the heads up. I just didn't want to merge it if anyone was mid review. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously blocked raid0 disk removal outright. Move to allowing device removal, as per all other profiles, within profile limits.
Abstract btrfs-raid profile minimum device count & maximum device missing info and use the former through-out the fencing code. Adapt all related tests to the newly uniform error messages that result from hitting the remaining revised limitations.
These code changes are also intended to ease our adoption of raid1c3 & raid1c4 profiles. And form the initial awareness of these newer btrfs-raid profiles.
Fixes #2385
Testing
An existing subtest was modified from the older behaviour to what is proposed, and a previously missing sub-test was added for below minimum dev count on the single profile.
With the proposed changes we have the following: