repeated log errors on disabled quotas (#2236) #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove explicit logging of key 'btrfs qgroup show' commands to avoid excessive log spamming. As we have now supported the pool quota disabled state mostly successfully for some time we can remove the initial default of always logging these commands which are reported as errors by the underlying btrfs commands when quotas are disabled on the parent pool. And hence are at odds with their supported state within the Rockstor Web-UI. In most common cases we catch and log as info in addition to the prior 'raw' command log. Prior explicit log parameters have been kept as explicit to ease reversing this change.
FroggyFlox
approved these changes
Feb 1, 2021
|
@FroggyFlox Thanks for the double check/review. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove explicit logging of key 'btrfs qgroup show' commands to avoid excessive log spamming. As we have now supported the pool quota disabled state mostly successfully for some time we can remove the initial default of always logging these commands which are reported as errors by the underlying btrfs commands when quotas are disabled on the parent pool. And hence are at odds with their supported state within the Rockstor Web-UI. In most common cases we catch and log as info in addition to the prior 'raw' command log.
Prior explicit log parameters have been kept as explicit to ease reversing this change.
Includes minor comment typo.
Fixes #2236
Ready for review.
Testing
Pre pr
With a ROOT pool, quota disabled, a Shares refresh page produces the following log entry:
Post pr
There is no ERROR message produced.
N.B. there are still error states that we wish to surface and they should still be logged or surfaced. But for the time being this patch reduces our mostly redundant a and potentially misleading 'ERROR' log spamming for known common btrfs quota disabled states.