Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arm64-efi system pool subvol exclusion. Fixes #2186 #2187

Conversation

phillxnet
Copy link
Member

Add boot/grub2/arm64-efi subvol exclusion to our existing system pool subvol exclusions. As an appliance we attempt to hide the less commonly applicable shares as they relate only to the system directly.

Fixes #2186

Summary:

Please see issue text for a little more info:

Testing:

Prior to pr we have:
aarch64-home-plus-arm64-efi-pre-pr
Post pr we have:
aarch64-home-only-post-pr

And the consequent debug log entries also indicate a purposeful exclusion post pr:

[24/Jun/2020 16:14:32] DEBUG [fs.btrfs:779] Skipping excluded subvol: name=(@).                                                                
[24/Jun/2020 16:14:32] DEBUG [fs.btrfs:779] Skipping excluded subvol: name=(.snapshots).                                                       
[24/Jun/2020 16:14:32] DEBUG [fs.btrfs:779] Skipping excluded subvol: name=(opt).                                                              
[24/Jun/2020 16:14:32] DEBUG [fs.btrfs:779] Skipping excluded subvol: name=(root).                                                             
[24/Jun/2020 16:14:32] DEBUG [fs.btrfs:779] Skipping excluded subvol: name=(srv).                                                              
[24/Jun/2020 16:14:32] DEBUG [fs.btrfs:779] Skipping excluded subvol: name=(tmp).                                                              
[24/Jun/2020 16:14:32] DEBUG [fs.btrfs:779] Skipping excluded subvol: name=(var).                                                              
[24/Jun/2020 16:14:32] DEBUG [fs.btrfs:779] Skipping excluded subvol: name=(usr/local).                                                        
[24/Jun/2020 16:14:32] DEBUG [fs.btrfs:779] Skipping excluded subvol: name=(boot/grub2/arm64-efi).                                             
[24/Jun/2020 16:14:33] DEBUG [fs.btrfs:779] Skipping excluded subvol: name=(.snapshots/18/snapshot).                                           
[24/Jun/2020 16:14:34] DEBUG [storageadmin.views.share_helpers:111] ---- Share name = home.                                                    
[24/Jun/2020 16:14:34] DEBUG [storageadmin.views.share_helpers:113] Updating pre-existing same pool db share entry. 

Note that debug logging was enable via:

/opt/rockstor/bin/debug-mode ON

Add boot/grub2/arm64-efi subvol exclusion to our existing system pool
subvol exclusions. As an appliance we attempt to hide the less
commonly applicable shares as they relate only to the system directly.

Summary:
- Builds on "add root subvol exclusion mechanism. Fixes rockstor#1931" pr.
- Includes both non boot to snap, and boot to snap patterns.
@phillxnet
Copy link
Member Author

@FroggyFlox I'm included to pop this one in without formal review as it's essentially proven and trivial; and involves no additional mechanism. We can then include it in our next release so we don't surface this sensitive subvol unnecessarily on efi aarch64 builds.

@FroggyFlox
Copy link
Member

@phillxnet, I agree.

Thanks for taking care of this!

@phillxnet
Copy link
Member Author

@FroggyFlox Cheers. I'll get this merged so I can set to on the remaining architecture awareness issue.

@phillxnet phillxnet merged commit 4c810e1 into rockstor:master Jun 24, 2020
@phillxnet phillxnet deleted the 2186_add_arm64-efi_system_pool_subvol_exclusion branch June 24, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add arm64-efi system pool subvol exclusion add root subvol exclusion mechanism
2 participants