improve pool import with disabled or indeterminate quota state. Fixes #1987 #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or#1987 Add sensitivity / heed warnings re a quota disabled state (often only displayed for a short period and accompanied by otherwise normal quota enabled behaviour) and additionally make our 'btrfs qgroup assign' wrapper fail elegantly in this interim / indeterminate quota state. Addressed issue could in rare situations also block share creation. Summary: - Enhance qgroup_max() re qgroup disabled warnings. - Enhance are_quotas_enabled() re qgroup disabled warnings. - Don’t fail import / share creation for failure to quota group assign: log as error and continue.
|
Thank you @phillxnet |
|
@schakrava Cheers, and thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sensitivity / heed warnings re a quota disabled state (often only displayed for a short period and accompanied by otherwise normal quota enabled behaviour) and additionally make our 'btrfs qgroup assign' wrapper fail elegantly in this interim / indeterminate quota state.
Addressed issue could in rare situations also block share creation.
Summary:
Fixes #1987
See issue text for more context.
@schakrava Ready for review.
Testing:
During unrelated Rockstor development on docker-ce a larger number of docker service enable / disable cycles were performed. This is suspected as the cause for a then persistent indeterminate quota state that blocked further share creation. See issue:
"docker-ce dictating pool quota enabled disabled status" #1906
for buggy docker-ce btrfs quota interaction.
It was then also noticed that importing certain prior quota disabled pools failed in a related manner.
Post pr the remaining reproducer examples behaved as expected, ie share creation was fixed and imports were successful in the respective instances.