fix scheduled scrub regression re pool api changes. Fixes #1759 #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update UI input to pass pool id not name as per new api. Also adds pool_name to meta field and backbone model of scrub tasks to enable scheduled task interfaces to report the pool name.
This was referenced Jul 14, 2017
Closed
|
As a duplicate issue this pr addresses has been identified I am adding the following "also" Fixes: Fixes #1762 |
|
Thank you @phillxnet |
|
@schakrava Cheers. |
This was referenced Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @kbogert, @MFlyer, and KarstenV on the forum for helping to diagnose the associated issue.
Update UI input to pass pool id not name as per new api. Also adds pool_name to meta field and backbone model of scrub tasks to enable scheduled task interfaces to report the associated pool name.
Some minor cosmetic spacing adjustments were also included in UI pool name display elements.
Fixes #1759
@schakrava Ready for review
Please see the associated issue text and the following forum thread for historical context:
https://forum.rockstor.com/t/scheduled-scrub-throws-an-error/3448