work around failure of udev to observe btrfs device add. Fixes #1606 #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was found to be required to ensure lsblk and udev info was successfully updated after a btrfs device add command. The failed state of stale info was only rarely observed but was reproduced a number of times using both whole and partition pool members.
|
Ready for review. |
|
Sorry for taking so long to test this. I am really impressed with the amount of detail in the issue and code. Nicely done @phillxnet |
|
@schakrava Thanks and Cheers. Took a while to track this one down so at least we have the notes here if it ever need to be refined. |
|
If there's anyone who can track down such things, it's you! |
Closed
phillxnet
added a commit
to phillxnet/rockstor-core
that referenced
this pull request
May 19, 2017
Intermittent failure of udev to update fstype, label, and uuid of dev after pool creation (1-2 times in 10) was observed for a luks mapped device. After this udev call no similar failures were observed. Also prior to patch many mount by label fails were observed with consequent fail-over mounts by dev, but with no consequent dev info updates the pool was not recognized by our UI. Where as after this patch no failures to mount by label were observed in the test scenarios. This same treatment has already been applied to adding disks to an existing pool in pr rockstor#1607 commit: 0358560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare instances it is possible for udev and lsblk to fail to reflect the current state of a pools disk members. This was initially observed while testing btrfs in partition device members in issue #1494, however the same has now been reproduced using whole disk members.
Please see issue #1606 for examples of where this discrepancy was observed and the subsequent testing of 'udevadmin trigger' to cause udev and lsblk to again reflect the current state of btrfs pools. All proof was via command line to isolate any Rockstor mechanisms.
This pr creates a simple wrapper around 'udevadmin trigger' and calls this directly after a pool resize action is requested to add one or more devices. The call method mimics that of resize_pool() for consistency. Exception handling was tested by substituting a nonsense command, in this scenario a user visible error was returned.
Fixes #1606
This pr was made against current master and a fresh build was used for testing.