Fixing Issue#1567 datacollector orm to api migration #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added urls to Pincard view Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
Pincard simple rfc view added to Rockstor Our new Pincard view handles only POST requests for password reset and Pincard creation All read ops till under data_collector - as suggested by @schakrava Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
…Wrapper To @schakrava Having your suggestions on previous issue had db write ops via APIwrapper: create_pincard and password_reset now run on APIwrapper with 2 POST requests check_has_pincard still on ORM having only small readings (check email not enabled, check if user pincard exist and grab 4 random pins) Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
Signed-off-by: Mirko Arena <mirko.arena@gmail.com>
|
Thank you @MFlyer. Nicely done as always! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @schakrava ,
had my way to #1567 following your suggestions about CRUD ops
Checking comments on commits you'll find checking pincard existence is always with direct db reading (as you suggested it possible on #1556 )
Note: Pincard view is a small one because the system/pinmanager already had all checks
Tests performed:
Ready for your review / to be merged
Mirko