3.8 14.03 broke samba config. May fix #1385 #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r#1385 When reading from the /etc/samba/smb.conf file to populate the new custom config [global] section we need a final check on the field count to avoid tripping up on for example empty options or just indented remarks.
A recent refactoring has orphaned this variable, previously this was passed as a parameter.
|
Thanks @phillxnet . I've cleaned up the code a bit myself. |
|
@schakrava Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@schakrava I've run out of time on this one for today but to ease hand over I've created this pr.
However I think with this pr the new samba config global import / update mechanism is now working as intended. And is best tested by yourself in this case anyway.
N.B. Very little (next to none) testing but parser now appears to import existing [global] config correctly and also appears to re-write this config correctly.
So over to you for review / testing.
Please see issue #1385 for the development history that lead to this issue.