enhance scan disks for md #1063 #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
md* (multi device) block devices such as software raid and some hardware raid devices are listed multiple times in lsblk output, this causes them to be labeled as duplicate devices due to shared serial number and any serial number retrieved on the first occurrence is over-ridden on the second occurrence by a fake to denote serial, and hence device, duplication. This is incorrect in the case of these md devices.
|
Haven't managed to install system disk on software raid as installer doesn't offer btrfs with raid. This would be a nice one to work out though. Can be done via installer if one selects eg XFS as root but then we arn't testing Rockstor as is. Also doesn't seem to present identically as original poster's system as their intel motherboard hardware md is presented as a partitioned md where as the installer goes with multiple md devices in software raid. So not equivalent. May revisit this attempt but taking too long. Would be nice to document a working solution when found though. |
|
Thanks @phillxnet! |
schakrava
added a commit
that referenced
this pull request
Dec 30, 2015
enhance scan disks for md #1063
|
Cheers @schakrava |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of md devices such as software raid ie mdadm and some hardware raid, the md devices and their respective partitions have repeat listings in lsblk, this accidentally triggers the duplicate device by serial number mechanism as the entries are identical; the consequence of this is a fail-safe that overrides the serial on the second occurrence (which has the same dev name) with a unique but fake serial. Avoid this udev assigned serial accidental override by only processing the first occurrence of each device by name in the lsblk output.
@schakrava I will have another go at testing this on a software raid system disk tomorrow (UK).