-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pyproject.toml's 'version' in build.sh #2895
Comments
What we need here is something already available with our existing openSUSE repos akin to: Or:
|
Re:
Given in
to record in poetry-install.txt our live version of Poetry itself. A simple sed/parse or the like of "poetry version"'s output of "rockstor 5.0.14" should be safe to use as a means to set our bash Our most recent poetry-install.txt currently already contains our overall 'rockstor' package version, e.g:
via our current use in build.sh of:
|
Use pyproject.toml's (version = "5.0.14") via `poetry version` output: e.g. "rockstor 5.0.14" to populate jslibs_version variable within build.sh. Intended to ease project versioning/release strategies by having a single point of reference for release versions. Typically rockstor-jslibs has a GitHub released in parallel with rockstor-core. Includes a minor build.sh logging fix re .env file source directory.
…rsion'-in-build.sh Use pyproject.toml's 'version' in build.sh #2895
Closing as: |
It is proposed that we normalise/centralise on the
version
defined in pyproject.toml within build.sh when setting thejslibs_version
bash variable. This should ease further the procedures required to release rpms: where we synchronise GitHub releases to these version numbers.The text was updated successfully, but these errors were encountered: