Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test improvements re Disk miss-attribution to ROOT pool #2828

Closed
phillxnet opened this issue Apr 3, 2024 · 1 comment
Closed

Unit test improvements re Disk miss-attribution to ROOT pool #2828

phillxnet opened this issue Apr 3, 2024 · 1 comment
Assignees
@phillxnet
Milestone
5.1.X-X Stable re...

Comments

@phillxnet
Copy link
Member

Spin-off issue to assert unit test reproducers for:

so that we can include these test enhancement in the planned simplification covered by:

where the latter is proposed to include a fix for the former. Making this issue's resollution a dependency of the latter.
@phillxnet phillxnet self-assigned this Apr 3, 2024
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Apr 3, 2024
@phillxnet
Unit test improvements re Disk miss-attribution to ROOT pool rockstor…
4234ac3 
…#2828

Revive/fix prior test_root_disk() awaiting now completed Py3.11 transition.
Add test data to test_root_disk() re root on sdag4 dev.
Add reproducer test for ROOT on sdag4 with sda as a data pool drive, where
a failure was reported to properly label the root device, and a
miss-attribution of sda to the ROOT pool was reported within the Web-UI.

Includes a minimum reproducer test. The full real-system command output
derived test is maintained as it represents a typical larger disk count
install (36). And so may help in future assertions of intended behaviour.
@phillxnet phillxnet mentioned this issue Apr 3, 2024
Merged
@phillxnet phillxnet added this to the 5.1.X-X Stable release milestone Apr 3, 2024
phillxnet added a commit that referenced this issue Apr 3, 2024
@phillxnet
Merge pull request #2829 from phillxnet/2828-Unit-test-improvements-r…
6c6acb4 
…e-Disk-miss-attribution-to-ROOT-pool

Unit test improvements re Disk miss-attribution to ROOT pool #2828
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #2829

@phillxnet phillxnet mentioned this issue Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
None yet
Projects
None yet
Milestone
5.1.X-X Stable release
Development

No branches or pull requests
1 participant
@phillxnet