-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt net interface delete to 'rockstor' service null config default #2819
Comments
It is proposed that, given the current default of null for the 'rockstor' service, and via the above detailed aims to have this as the service norm: that we accommodate appropriately and simple circumvent this check when there is no definition of a management interface yet available. A spin-off dedicated issue could be created to address the need to auto-establish a non-null config for the Web-UI/management interface but that is outside the scope of this issue. And given our stated context of approaching a system-wide null config capability: we should similarly not fail in the current manner indicated by the quoted log entry (post merge of #2817 which then clears the way for a reproducer here). |
…ockstor#2819 Block non-rocknet interface deletions for the default/no management/Web-UI interface configuration. Raising a user visible exception explaining the interface delete rejection, and advising the need to configure the 'rockstor' service first. This way, for default/no 'rockstor'/Web-UI service configurations (no management interface defined) we avoid inadvertent Web-UI outage. Once a non default 'rockstor' service/Web-UI Network interface is established, only that interface will be bared from delete. Fixes Web-UI silent but logged failure to properly process/fence an interface delete request with default 'rockstor'/Web-UI configuration.
…te-to-'rockstor'-service-null-config-default Adapt net interface delete to 'rockstor' service null config #2819
Closing as: |
Almost all services have a default config of null: including the Web-UI service known as 'rockstor'. However when deleting an existing interface, with a default null config for the 'rockstor' service: we get the following log entry indicating a silent failure in our fencing to guard against inadvertent removal of the Web-UI associated 'management' interface.
See the following reproducer comment that arouse while testing a recent fix for network interface removal via Web-UI:
#2817 (comment)
And the following contextual issues/design directions:
The text was updated successfully, but these errors were encountered: