Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django-pipeline to latest #2689

Closed
phillxnet opened this issue Oct 10, 2023 · 3 comments
Closed

Update django-pipeline to latest #2689

phillxnet opened this issue Oct 10, 2023 · 3 comments
Assignees
Milestone

Comments

@phillxnet
Copy link
Member

phillxnet commented Oct 10, 2023

Our remaining "RemovedInDjango31Warning: CachedStaticFilesStorage is deprecated in favor of ManifestStaticFilesStorage" appears to be related to our currently pinned version django-pipeline, limited at the time to 1.7 due to our older Django. See: #2646 by @FroggyFlox :

It is thus proposed that we temporarily upgrade to django-pipeline 1.7 now, before further upgrading during our move to Django 2.2 LTS, for which support was added in jazzband/django-pipeline#693 (thanks to @phillxnet for finding that last one).

And we have the following in their changelog for 2.0.1:
https://github.com/jazzband/django-pipeline/blob/master/HISTORY.rst#201

  • Add subclass of ManifestStaticFilesStorage. Thank to @jhpinson
  • Change the documentation to use PipelineManifestStorage in configuration instead of PipelineCachedStorage now deprecated.
  • ...

https://github.com/jazzband/django-pipeline/blob/master/HISTORY.rst#207

https://pypi.org/project/django-pipeline/2.0.9/
is the last to specifically mention Py3.6 however no specific dropping of Py3.6 has yet been found: still looking!

Current is 2.1.0: https://pypi.org/project/django-pipeline/


This issue is a follow-up to #2646 re our pending now merged in testing "Provisional Django 2.2 LTS update" #2625 (part of Milestone: https://github.com/rockstor/rockstor-core/milestone/22 ) and is a spin-off from the latter issue pertaining to comment: #2625 (comment)

@phillxnet phillxnet added this to the Django 3.2 milestone Oct 10, 2023
@phillxnet phillxnet changed the title Update django-pipeline Update django-pipeline within Django constrains Oct 10, 2023
@phillxnet phillxnet self-assigned this Oct 12, 2023
@phillxnet
Copy link
Member Author

It is proposed that we can now un-pin this dependency, allowing it to move with our ongoing Django Py updates. The latest version on PyPi indicates Django 2.2 and Py3.9 compatibility.

@phillxnet
Copy link
Member Author

phillxnet commented Oct 12, 2023

django-pipeline = "==1.7.0" # last version listed with Python 3.6 and Django 1.11 compatibility

We were previously held back to 1.7.0 by both our Python and Django versions.

lbuildvm:/opt/rockstor # poetry update
Updating dependencies
Resolving dependencies... (1.5s)

Writing lock file

Package operations: 0 installs, 1 update, 0 removals

  • Updating django-pipeline (1.7.0 -> 2.1.0)

@phillxnet phillxnet changed the title Update django-pipeline within Django constrains Update django-pipeline to latest Oct 12, 2023
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 12, 2023
Remove version pinning given we have now removed
the prior dual constraint re Python version and
Django version.
phillxnet added a commit that referenced this issue Oct 12, 2023
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #2694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant