-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(t) Update Middlewares style #2662
Comments
We currently have the following: rockstor-core/src/rockstor/settings.py Lines 148 to 158 in 3f87942
We thus have:
Note the following from Django's documentation:
We should thus be OK for the middlewares included in Django that we use. |
In Django 1.10, the old `MIDDLEWARE_CLASSES` style was deprecated and we should now use `MIDDLEWARE` setting. This commit includes this move and takes advantage of the new MiddlewareMixin to help provide compatibility for our custom middleware.
Migrate to New Middleware style #2662
Closing as: |
Thanks to @phillxnet, we now have a config to run with the Python's warning flag (#2655).
One of these warnings is relates to our use of Middlewares:
This most likely relates to the deprecation of
MIDDLEWARE_CLASSES
in Django 1.10:https://docs.djangoproject.com/en/1.11/ref/settings/#middleware-classes
Note that this was fully removed from Django 2.0:
https://docs.djangoproject.com/en/4.2/releases/2.0/#features-removed-in-2-0
The text was updated successfully, but these errors were encountered: