Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rockstor build changes to .gitignore #2644

Closed
StephenBrown2 opened this issue Aug 7, 2023 · 1 comment
Closed

Rockstor build changes to .gitignore #2644

StephenBrown2 opened this issue Aug 7, 2023 · 1 comment

Comments

@StephenBrown2
Copy link
Contributor

StephenBrown2 commented Aug 7, 2023

@StephenBrown2 These changes to .gitignore are a nice addition actually - and yes I think it would be good to have them split out into their own issue/pull request set. We will then have them to point to for folks that want to add similar dev environment additions/enhancements such as these. It will also help with cherry picking these changes, in isolation, if they end up being required in another branch.

Thanks for thinking of this and highlighting it. Plus it will help to split out 'things' from one another. Always nice.
It can also help with reviewing to have stuff split down into more manageable chunks.

Originally posted by @phillxnet in #2641 (comment)

phillxnet added a commit that referenced this issue Aug 8, 2023
Update .gitignore with Rockstor build artifacts #2644
@phillxnet
Copy link
Member

Closing as:
Fixed by #2643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants