-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disposition of pytz package #2590
Comments
@Hooverdan96 I might of gone with update - but lets keep the fancy "Disposition" Nice. I favour it's removal form pyproject initially but will have to have a closer look as to if we actually use this directly. |
It is currently proposed that we remove our pytz specification all-together. It looks to be a secondary dependency of Django only currently:
This is also in keeping with removing less sensitive (simpler) second order explicit dependency pinning. We have our poetry.lock mechanism still for tracking these changes. |
Removing our entry entirely for pytz from pyproject.toml we get the following resolution via poetry:
|
Remove explicit request/versioning for this secondary Django dependency. Allowing for its update within the constraints of our specified Django version.
@FroggyFlox & @Hooverdan96 |
Current version:
2022.6
World timezone definitions, modern and historicalDue to ongoing changes of these definitions, this should be either bumped to
2023.3
in thepoetry.toml
file or, if possible not be required to be pinned anymore.rockstor-core/pyproject.toml
Line 63 in e965120
With Python 3.9 onwards it is recommended to utilize the built-in functionality instead of this package, which will then allow us to get rid of one more dependency definition.
I assume, since this is currently a django dependency, higher versions of django and python in later Rockstor milestones might resolve the need for this dependency, since, according to @phillxnet we are likely not using this anywhere else in our developments.
For reference:
https://pypi.org/project/pytz/2023.3/
The text was updated successfully, but these errors were encountered: