Py3.6 System - Scheduled tasks - snapshot & scrub

[phillxnet]

Post #2567 in testing branch we have a failure within our Web-UI to reflect a successfully executed snapshot task:
Reproducer - Create a snapshot of say the "home" share, limited to 2 copies with a 5 minute schedule. The resulting task is run by crontab but we fail (via our created script and call back, to update our database on the resulting execution and associated info:

Jun 05 19:30:01 buildvm CRON[22121]: (root) CMD (/opt/rockstor/.venv/bin/st-snapshot 1 \*-*-*-*-*-*)
Jun 05 19:30:02 buildvm CRON[22119]: (root) CMDEND (/opt/rockstor/.venv/bin/st-snapshot 1 \*-*-*-*-*-*)
...
Jun 05 19:35:01 buildvm CRON[23870]: (root) CMD (/opt/rockstor/.venv/bin/st-snapshot 1 \*-*-*-*-*-*)
Jun 05 19:35:01 buildvm CRON[23869]: (root) CMDEND (/opt/rockstor/.venv/bin/st-snapshot 1 \*-*-*-*-*-*)

[phillxnet]

We have a potentially corresponding unit test failure as follows:

======================================================================
FAIL: test_post_requests_2 (rockstor.storageadmin.tests.test_snapshot.SnapshotTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/rockstor/src/rockstor/storageadmin/tests/test_snapshot.py", line 156, in test_post_requests_2
    self.assertEqual(response.data[0], e_msg)
AssertionError: "Element 'uvisible' must be a boolean, not (<class 'str'>)." != "Element 'uvisible' must be a boolean, not (<type 'unicode'>)."
- Element 'uvisible' must be a boolean, not (<class 'str'>).
?                                              ^^^^^^^^^
+ Element 'uvisible' must be a boolean, not (<type 'unicode'>).
?                                             +++++++++ ^^^

Unit test failure likely unrelated and now fixed by #2581

[phillxnet]

Linking to related code changes having taken place since this issue was created #2579 where import fixes may have affected this issue. Re-testing now.

[phillxnet]

We have a running schedule instantiated via Web-UI with consequent triggers from cron evident:

Jun 07 18:00:01 buildvm CRON[18867]: (root) CMD (/opt/rockstor/.venv/bin/st-snapshot 2 \*-*-*-*-*-*)
Jun 07 18:00:02 buildvm CRON[18865]: (root) CMDEND (/opt/rockstor/.venv/bin/st-snapshot 2 \*-*-*-*-*-*)

But:

buildvm:/opt/rockstor # /opt/rockstor/.venv/bin/st-snapshot 2 \*-*-*-*-*-*
Traceback (most recent call last):
  File "/opt/rockstor/.venv/bin/st-snapshot", line 2, in <module>
    from scripts.scheduled_tasks.snapshot import main
  File "/opt/rockstor/src/rockstor/scripts/scheduled_tasks/snapshot.py", line 22, in <module>
    import crontabwindow  # load crontabwindow module
ModuleNotFoundError: No module named 'crontabwindow'

Given the above we have a continuation her of: #2579

[Hooverdan96]

again, unrelated to this specifically, but I think there is another instance where the crontab needs to be adjusted:

rockstor-core/src/rockstor/scripts/scheduled_tasks/pool_scrub.py

Line 23 in b04fb03

import crontabwindow # load crontabwindow module

[phillxnet]

@Hooverdan96 Thanks. Yes I'm preparing a pr for both instances now. And have broadened the commit messages accordingly. We are getting there here I think. And these took longer as there was no test coverage !!

[phillxnet]

Closing as:
Fixed by #2585