Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pyproject.toml and poetry.lock for python 3.6 #2564

Closed
phillxnet opened this issue Jun 1, 2023 · 1 comment
Closed

Update pyproject.toml and poetry.lock for python 3.6 #2564

phillxnet opened this issue Jun 1, 2023 · 1 comment
Milestone
Python 3 within D...

Comments

@phillxnet
Copy link
Member

phillxnet commented Jun 1, 2023 •
edited
Loading

As part of our move to Python 3 we must first establish our new python 3 dependencies via Poetry. And resolve all issues re dependencies from there on. Along with resolving any Python 3 incompatibilities within our own code.

May involve spin-off issue/pull-request pairs.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 1, 2023
@phillxnet
Update pyproject.toml and poetry.lock for python 3.6 rockstor#2564
0fabcc5 
As part of our move to Python 3 we must first establish our
new python 3 dependencies via Poetry. And resolve all issues
re dependencies from there on.
This was referenced Jun 1, 2023
Closed
Closed
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 1, 2023
@phillxnet
Remove int long designator from settings.py rockstor#2564
3060395 
Python 3 no longer uses the "L" suffix:
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 1, 2023
@phillxnet
use full path in initial import conversions rockstor#2564
ce14ed7 
Python 3 has more stringent import path requirements.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 2, 2023
@phillxnet
update imports for 3.6 email module rockstor#2564
7f69ef2
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 2, 2023
@phillxnet
more use full path in initial import conversions rockstor#2564
6ab781d 
Python 3 has more stringent import path requirements.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 2, 2023
@phillxnet
encode unicode line for system.osi.md5sum rockstor#2564
f55dc44 
md5.update(l)
TypeError: Unicode-objects must be encoded before hashing
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 2, 2023
@phillxnet
tidy/update init_sftp_config() re Python 3 rockstor#2564
31a273a 
There was a subtle file pointer behaviour change
between 2.7 and 3.6 which broke this mechanism.
Address TODO re custom opener re Python 3.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 3, 2023
@phillxnet
fix services page - Python 3 style sorted() rockstor#2564
b179416 
"cmp" sorted parameter and buildin function dropped
in Python 3.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 3, 2023
@phillxnet
partially fix users page - Python 3 style sorted() rockstor#2564
9a4dd5f 
"cmp" sorted parameter and builtin function dropped
in Python 3.
Partial fix as only Admin users showing - suspect unrelated
issue.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 3, 2023
@phillxnet
init fix of groups page by adaptation to str type rockstor#2564
b56967c 
Replace hard chardet dependency with soft
charset-normalizer also used by requests.
Removes redundant encoding on groupname already
encoded.
FroggyFlox added a commit to FroggyFlox/rockstor-core that referenced this issue Jun 3, 2023
@FroggyFlox
Move passwd to str and use crypt.mksalt() to generate salt rockstor#2564
a174691
FroggyFlox added a commit to FroggyFlox/rockstor-core that referenced this issue Jun 4, 2023
@FroggyFlox
Move UDEVADM and SHUTDOWN definitions to runtime constants rockstor#2564
308232e
FroggyFlox added a commit to FroggyFlox/rockstor-core that referenced this issue Jun 4, 2023
@FroggyFlox
Move UDEVADM and SHUTDOWN definitions to runtime constants rockstor#2564
e373ee1
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 5, 2023
@phillxnet
Merge pull request #3 from FroggyFlox/2564_Move_BIN_def_from_build_to…
3635546 
…_runtime

Move UDEVADM and SHUTDOWN definitions to runtime constants rockstor#2564
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 5, 2023
@phillxnet
Merge pull request #2 from FroggyFlox/2564_Update_pyproject.toml_and_…
5525d6c 
…poetry.lock_for_python_3.6

Move passwd to str and use crypt.mksalt() to generate salt rockstor#2564
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 5, 2023
@phillxnet
init dashboard fix via gevent/websocket update rockstor#2564
d655796 
Thanks to @FroggyFlox for investigations here.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 5, 2023
@phillxnet
init fix of get_users() - non admin users now found rockstor#2564
1eee2ca 
Move to more modern - time limited subprocess.run().
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 5, 2023
@phillxnet
fix samba, disk partition, rockon, re iteritems(d) rockstor#2564
7f8d633 
In Python 3 we use iter(d.items()) instead:
https://peps.python.org/pep-0469/
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 6, 2023
@phillxnet
minor tidy-ups & unused import rockstor#2564
6edcdb1 
Includes prior TODO re ascii to utf-8 on SMART
custom options.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 6, 2023
@phillxnet
untested bytecast in smart.py rockstor#2564
c53966a 
Custom options autodev related byte assertion.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 6, 2023
@phillxnet
Preliminary python 3.6 port rockstor#2564
316654c 
As part of our move to Python 3 we must first establish our
initial python 3 dependencies via Poetry.

## Includes:
- Update pyproject.toml and poetry.lock for python 3.6.
- Remove int long designator from settings.py: Python 3
no longer uses the "L" suffix.
- Use full path in initial import conversions. Python 3
has more stringent import path requirements.
- Update imports for 3.6 email module. These differ in Python 3.
- Encode unicode line for system.osi.md5sum.
TypeError: Unicode-objects must be encoded before hashing
- Tidy/update init_sftp_config() re Python 3.
There was a subtle file pointer behaviour change
between 2.7 and 3.6 which broke this mechanism.
- Address TODO re custom opener re Python 3.
- Services page & Users page - Python 3 style sorted():
"cmp" sorted parameter and buildin function dropped
in Python 3.
- init fix of groups page by adaptation to str type.
- Replace chardet dependency with charset-normalizer:
also used by requests.
- Removes redundant encoding on already encoded groupname.
- Init dashboard fix via gevent/websocket update.
Thanks to @FroggyFlox for investigations here.
- Init fix of get_users() - non admin users did not show.
Move to more modern - time limited subprocess.run().
- fix samba, disk partition, rockon, re iteritems()
In Python 3 we use iter(d.items()) instead:
https://peps.python.org/pep-0469/
- Address TODO re ascii to utf-8 on SMART custom options.
- Untested bytecast in smart.py:
custom options autodev related byte assertion.
phillxnet pushed a commit to phillxnet/rockstor-core that referenced this issue Jun 6, 2023
@FroggyFlox @phillxnet
Move UDEVADM and SHUTDOWN definitions to runtime constants rockstor#2564
22f49c2
phillxnet pushed a commit to phillxnet/rockstor-core that referenced this issue Jun 6, 2023
@FroggyFlox @phillxnet
Move passwd to str and use crypt.mksalt() to generate salt rockstor#2564
83563ab
@phillxnet phillxnet mentioned this issue Jun 6, 2023
Merged
phillxnet added a commit that referenced this issue Jun 6, 2023
@phillxnet
Merge pull request #2567 from phillxnet/2564_Preliminary_python_3.6_port
e8c98b6 
Preliminary python 3.6 port - development #2564
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #2567

@phillxnet phillxnet mentioned this issue Jun 7, 2023
Merged
@phillxnet phillxnet mentioned this issue Nov 20, 2023
Closed
@Hooverdan96 Hooverdan96 mentioned this issue Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Python 3 within Django constrains
Development

No branches or pull requests
1 participant
@phillxnet