Enabling samba doesn't always trigger configuration

[defmonk0]

When enabling samba from the UI under services, it opens an edit modal where you can supply a workgroup and custom global config. Filling out this config then overwrites the /etc/samba/smb.conf file with the defaults needed for Rockstor.

The relevant code for this can be found here:

rockstor-core/src/rockstor/storageadmin/static/storageadmin/js/views/services.js

Lines 137 to 147 in fd3d072

	if (this.configurable_services.indexOf(serviceName) > -1 && !serviceModel.get('config') && state) {
	app_router.navigate('services/' + serviceName + '/edit', {
	trigger: true
	});
	} else {
	if (state) {
	this.startService(serviceName);
	} else {
	this.stopService(serviceName);
	}
	}

This code is generic to be reused for all services listed on that page, but has a check to navigate to the edit URI if needed.

If instead you navigate to Storage->File Sharing->Samba and use the toggle there, this edit modal is never presented. This means if it has not previously been configured, this will enable samba with the default smb.conf supplied at install time.

The relevant code for this is here:

rockstor-core/src/rockstor/storageadmin/static/storageadmin/js/views/samba.js

Lines 106 to 112 in ba0ee33

	switchStatus: function(event, state) {
	if (state) {
	this.startService();
	} else {
	this.stopService();
	}
	},

This lacks any check at all for the configuration required.

---

Another example that came up during discussion is the Rock-Ons service, which properly presents the edit dialog in both locations. This is the expected behavior.

It can be seen here that it still checks for the config before toggling the service:

rockstor-core/src/rockstor/storageadmin/static/storageadmin/js/views/docker_service.js

Lines 69 to 81 in ba0ee33

	switchStatus: function(event, state) {
	if (!this.service.get('config')) {
	app_router.navigate('services/docker/edit', {
	trigger: true
	});
	} else {
	if (state) {
	this.startService();
	} else {
	this.stopService();
	}
	}
	},