Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openSUSE] improve JeOS compatibility re ROOT label #2062

Closed
phillxnet opened this issue Aug 13, 2019 · 2 comments · Fixed by #2063
Closed

[openSUSE] improve JeOS compatibility re ROOT label #2062

phillxnet opened this issue Aug 13, 2019 · 2 comments · Fixed by #2063

Comments

@phillxnet
Copy link
Member

OpenSUSE JeOS defaults to mounting by label. This differs from current openSUSE Leap 15.* and Tumbleweed that use mount by UUID. Both Leap and Tumbleweed also currently default to having no root volume label. Rockstor expects and enforces btrfs volume labels, using the btrfs volumes UUID in the case of data pools and 'system' in the case of root pools. However btrfs based openSUSE JeOS (Just enough Operating System) images default to a root volume (pool in Rockstor speak) label of "ROOT".

It is proposed that we adopt this "ROOT" default in favour of our existing "system" one to improve our JeOS compatibility and enable a consistent experience re system pool naming across Leap 15.* Tumbleweed and openSUSE JeOS image based installs.

This change should only affect existing openSUSE source based installs. But is intended to be in-place prior to distributing openSUSE based rpms.
@phillxnet
Copy link
Member Author

I am preparing a pull request to address this issue.

@phillxnet phillxnet changed the title [openSUSE] improve JeOS compatability re ROOT label [openSUSE] improve JeOS compatibility re ROOT label Aug 13, 2019
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Aug 13, 2019
@phillxnet
[openSUSE] improve JeOS compatibility re ROOT label rockstor#2062
3e6e749 
Summary of changes:
- Change 'no root pool label' auto label mechanism to use 'ROOT'; in
line with btrfs based openSUSE JeOS images.
- Provide a mechanism to migrate existing source installs over to this
new default: prior default was 'system'.
@phillxnet phillxnet mentioned this issue Aug 13, 2019
Merged
@phillxnet
Copy link
Member Author

The following indicates the outcome on next system boot if we inadvertently change a root (system) pools label on a JeOS based install away from it's expected default of "ROOT":

Broken-boot-on-system-label

phillxnet added a commit that referenced this issue Sep 22, 2019
@phillxnet
Merge pull request #2063 from phillxnet/2062_openSUSE_improve_JeOS_co…
9557493 
…mpatability_re_ROOT_label

[openSUSE] improve JeOS compatibility re ROOT label. Fixes #2062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[openSUSE] improve JeOS compatibility re ROOT label. Fixes #2062 phillxnet/rockstor-core
1 participant
@phillxnet