Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Docker container labels #1998

Closed
FroggyFlox opened this issue Dec 8, 2018 · 0 comments · Fixed by #2010
Closed

Support Docker container labels #1998

FroggyFlox opened this issue Dec 8, 2018 · 0 comments · Fixed by #2010

Comments

@FroggyFlox
Copy link
Member

Many Docker containers now make use of containers labels and allowing the user to specify labels would be much helpful in establishing multi-containers and even multi-Rock-ons environment.

As there isn't--to the best of my knowledge--support for container labels to docker update, this would need to be done at docker run time, which in Rockstor could be done either at the RockOn definition stage (using the options object) or using the update function. As labels would be specific to each user's environment, the latter is greatly preferred.

I thus suggest to implement an "Add label" feature from the Rock-On Settings page, similar to the existing "Add Storage" feature. This would also need to support adding several labels at once as multiple labels are usually needed to setup a custom multi-container multi-RockOn environment.

I'm currently finishing a related branch and will prepare the PR quite shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant