Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin python-engineio to 2.3.2 as recent 3.0.0 update breaks gevent #1995

Closed
phillxnet opened this issue Nov 25, 2018 · 2 comments · Fixed by #1996 or #2010
Closed

pin python-engineio to 2.3.2 as recent 3.0.0 update breaks gevent #1995

phillxnet opened this issue Nov 25, 2018 · 2 comments · Fixed by #1996 or #2010

Comments

@phillxnet
Copy link
Member

As of 25th November 2018 source builds failed to display live Web-UI header info such as time, Rockstor and kernel version etc. This was tracked down to an upstream python-engineio updated to 3.0.0. Although this update may not be the direct cause, pinning it's version to the latest prior released resolved the observed regressions.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Nov 25, 2018
@phillxnet
pin python-engineio to 2.3.2 as recent 3.0.0 update breaks gevent roc…
9578c8f 
…kstor#1995

As of 25th November 2018 source builds failed to display live Web-UI
header info such as time, Rockstor and kernel version etc. This was
tracked down to an upstream python-engineio updated to 3.0.0. Although
this update may not be the direct cause, pinning it's version to the
latest prior released resolved the observed regressions.
@phillxnet phillxnet mentioned this issue Nov 25, 2018
Merged
@phillxnet phillxnet mentioned this issue Jan 13, 2019
Closed
@phillxnet phillxnet mentioned this issue Jan 27, 2019
Merged
@phillxnet
Copy link
Member Author

Closing as fixed in upstream version of python-engineio. Last tested version v3.3.0.
See associated and closed without merge pull request:
"pin python-engineio to 2.3.2 as recent 3.0.0 update breaks gevent. Fixes #1995" #1996

phillxnet added a commit that referenced this issue Oct 6, 2019
@phillxnet
Merge pull request #1996 from phillxnet/1995_pin_python-engineio_to_2…
ab85aea 
….3.2_as_recent_3.0.0_update_breaks_gevent

pin python-engineio to 2.3.2 as recent 3.0.0 update breaks gevent. Fixes #1995
@phillxnet
Copy link
Member Author

This issue arose again in Rockstor 3.9.2-49 so applying as was for a quick fix.
Symptoms affect mainly webkit browsers: Chrome, Opera, etc and resulted in 10-30 second pauses in Web-UI along with dysfunctional Dashboard:

chrome-slow-UI

Firefox was mostly not affected however.

We can re-visit this pinned version again in the future, but as this was a know good version for us reverting ready for quick fix Rockstor version 3.9.2-50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@phillxnet