Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in unit tests - environment outdated since 3.9.2-45 #1993

Closed
phillxnet opened this issue Nov 23, 2018 · 1 comment · Fixed by #1994 or #2010
Closed

regression in unit tests - environment outdated since 3.9.2-45 #1993

phillxnet opened this issue Nov 23, 2018 · 1 comment · Fixed by #1994 or #2010

Comments

@phillxnet
Copy link
Member

Since 3.9.2-45 build changes were introduced that added several distro aware project wide settings. These changes, relating in this case to Django settings, were not carried over to our test-settings.conf.in. The result is that our unit tests fail to run due to these missing project settings definitions:

./bin/test --settings=test-settings -v 3 -p test_btrfs*
...
AttributeError: 'Settings' object has no attribute 'SHUTDOWN'
@phillxnet
Copy link
Member Author

I am currently preparing a pr for this issue.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Nov 23, 2018
@phillxnet
regression in unit tests - environment outdated since 3.9.2-45 rockst…
d58d8f2 
…or#1993

Adds previously omitted python imports and associated settings to
template file test-settings.conf.in. These same changes were
previously only applied to the non testing environment template file
settings.conf.in.

Fixes test_btrfs* runs.
@phillxnet phillxnet mentioned this issue Nov 23, 2018
Merged
@phillxnet phillxnet mentioned this issue Jan 27, 2019
Merged
phillxnet added a commit that referenced this issue Feb 23, 2019
@phillxnet
Merge pull request #1994 from phillxnet/1993_regression_in_unit_tests…
957d7ef 
…_-_environment_outdated_since_3.9.2-45

regression in unit tests - environment outdated since 3.9.2-45. Fixes #1993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@phillxnet