Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve by-id device name retrieval #1936

Closed
phillxnet opened this issue Jun 9, 2018 · 1 comment
Closed

improve by-id device name retrieval #1936

phillxnet opened this issue Jun 9, 2018 · 1 comment

Comments

@phillxnet
Copy link
Member

Under certain systemd/udev configurations it was found that the current get_dev_byid_name() method was unable to retrieve an available /dev/disk/by-id name, failing over to the canonical temp sda type names. This was observed in a pre-release testing environment but could affect any similarly custom configured released Rockstor instances, but has not been seen or reported as such. It was also noted that in circumstances where 2 or more by-id names have identical lengths the same method was not deterministic; this is a universal issue but should be a rare occurrence.
@phillxnet
Copy link
Member Author

I am currently working on this issue.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jun 10, 2018
@phillxnet
improve by-id device name retrieval rockstor#1936
8038c85 
Some systemd/udev configs can push DEVLINKS from the top line of udevadm
output: breaking an assumption made in get_dev_byid_name().

- Remove assumption that DEVLINKS line is first presented by udevadm.
- Debug log if no DEVLINKS line was found.
- Error log if device node not found.
- Ensure determinism with multiple same length by-id names for the same
device: ie via device links list sort prior to selection and return.
- Add unit tests for get_dev_byid_name() to cover existing desired and
above modified behaviour.
- Refactor for readability / simplification.
- Fix existing minor flake8 compliance in osi.py.
@phillxnet phillxnet mentioned this issue Jun 10, 2018
Merged
schakrava added a commit that referenced this issue Jun 19, 2018
@schakrava
Merge pull request #1937 from phillxnet/1936_improve_by-id_device_nam…
fd3d072 
…e_retrieval

improve by-id device name retrieval. Fixes #1936
@phillxnet phillxnet mentioned this issue Oct 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phillxnet