Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent root pool mount edit options #1861

Closed
phillxnet opened this issue Dec 3, 2017 · 0 comments · Fixed by #1899
Closed

inconsistent root pool mount edit options #1861

phillxnet opened this issue Dec 3, 2017 · 0 comments · Fixed by #1899
Assignees
@phillxnet
Labels
bug

Comments

@phillxnet
Copy link
Member

Thanks to forum member razaborg in the following thread for helping to highlight this issue. In pool overview we have compression and extra mount options disabled for this pool, but in the same pool's details page these options are active. However any attempt to use them fails as we have backend preventative logic to catch these currently unsupported actions.

It is proposed that we also disable these currently dysfunctional options in the system pool details page to gain consistency and then address, at a later date, the 'special case' of changing this system pool's mount options.

Please update the following forum thread with this issues resolution:
https://forum.rockstor.com/t/unable-to-change-mount-options-for-the-rockstor-rockstor-pool/4128
@phillxnet phillxnet mentioned this issue Jan 1, 2018
Closed
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Feb 16, 2018
@phillxnet
empty compression setting on imported pools blocks extra mount options …
1379b5a 
…rockstor#1896

Newly created pools have Pool.compression set to 'no' however imported
pools, and the system pool, defaulted to Null / None for this field.
Consequently "Empty" was indicated by x-editable inline compression edit
on pool overview and detail pages. This entry and it's consequent value
failed the dual submission of compression and mount options.

Summary:

- Set imported pools to 'no' compression by default.
- Handle "Empty" output from inline editable of compression setting.
- Put "Empty" inline editable colour in line with links as not an error
contition (to allow of legacy imported pools).
- Change "Empty" legacy pool imports compression text to "Unset".
- Improve and normalise compression tooltip text.
- Add 'compression' and 'extra mount options' tooltips to Pool overview.
- Remove inconsistent root pool mount edit options see issue rockstor#1861 where
compression and mount options were offered on system drive details page.
- Display system Pool.compression and Pool.mnt_options as per other
pools but without edit options: i.e. 'no', if set, rather than 'OFF' as
hard wired.
@phillxnet phillxnet mentioned this issue Feb 16, 2018
Merged
@schakrava schakrava added the bug label Mar 5, 2018
This was referenced Apr 1, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@schakrava @phillxnet