Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrub task end time incorrect #1802

Closed
phillxnet opened this issue Aug 22, 2017 · 0 comments
Closed

scrub task end time incorrect #1802

phillxnet opened this issue Aug 22, 2017 · 0 comments
Assignees
@phillxnet
Labels
bug
Milestone
Point Bonita

Comments

@phillxnet
Copy link
Member

Thanks to forum member peter in the following forum post for highlighting this issue. The end time of pool scrub jobs is almost always around 2 seconds after the start time; indicating a bug in the update mechanism of this UI element. Note that the associated pool scrub end time, as presented on the relevant pool details page (scrub tab), is updated correctly.

A resolution to this bug has been found and a pull request is being prepared.

Please update the following forum thread with this issues resolution:
https://forum.rockstor.com/t/scheduled-scrub-not-running/3608/18
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Aug 22, 2017
@phillxnet
scrub task end time incorrectly updated rockstor#1802
ab53098 
Scrub task end times were incorrectly updated directly
after scrub task initialization. They were not updated
there after. This resulted in premature end times of
start time + 2 seconds.
Move end time update, and consequent db save, to
directly after current scrub state is assessed as terminal.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Aug 22, 2017
@phillxnet
scrub task end time incorrectly updated rockstor#1802
aaa65d1 
Scrub task end times were incorrectly updated directly
after scrub task initialization. They were not updated
there after. This resulted in premature end times of
start time + 2 seconds.
Move end time update, and consequent db save, to
directly after current scrub state is assessed as terminal.
@phillxnet phillxnet mentioned this issue Aug 22, 2017
Merged
schakrava added a commit that referenced this issue Aug 28, 2017
@schakrava
Merge pull request #1803 from phillxnet/1802_scrub_task_end_time_inco…
7951fc8 
…rrect

scrub task end time incorrectly updated. Fixes #1802
@schakrava schakrava added the bug label Aug 28, 2017
@schakrava schakrava added this to the Point Bonita milestone Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
bug
Projects
None yet
Milestone
Point Bonita
Development

No branches or pull requests
2 participants
@schakrava @phillxnet