Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

balance cancel requested 'unit test' false alarm. #1627

Closed
phillxnet opened this issue Jan 24, 2017 · 0 comments
Closed

balance cancel requested 'unit test' false alarm. #1627

phillxnet opened this issue Jan 24, 2017 · 0 comments
Assignees
@phillxnet
Labels
bug
Milestone
Point Bonita

Comments

@phillxnet
Copy link
Member

Thanks to @MFlyer for reporting this issue. In the background we have a unit test to check for correct balance 'cancel requested' status recognition. Due to a project wide refactoring pr recently #1615 that (almost) bring all Rockstor python code into compliance with Flake8 (mostly PEP8) standards, a minor error was introduced into this unit test.

./bin/test --settings=test-settings -v 2 -p test_btrfs*
test_balance_status_cancel_requested (fs.tests.test_btrfs.BTRFSTests) ... FAIL
...
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 24, 2017
@phillxnet
correct minor refactoring error on balance unit test rockstor#1627
79dd64f
@phillxnet phillxnet mentioned this issue Jan 24, 2017
Merged
schakrava added a commit that referenced this issue Feb 11, 2017
@schakrava
Merge pull request #1628 from phillxnet/1627_balance_cancel_requested…
e0048cf 
…_unit_test_false_alarm

correct minor refactoring error on balance unit test. Fixes #1627
@schakrava schakrava added the bug label Feb 11, 2017
@schakrava schakrava added this to the Point Bonita milestone Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
bug
Projects
None yet
Milestone
Point Bonita
Development

No branches or pull requests
2 participants
@schakrava @phillxnet