Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sysctl.conf optimizations should go into separate file #1598

Closed
maxhq opened this issue Jan 3, 2017 · 1 comment
Closed

Sysctl.conf optimizations should go into separate file #1598

maxhq opened this issue Jan 3, 2017 · 1 comment
Assignees
@schakrava
Labels
enhancement
Milestone
Point Bonita

Comments

@maxhq
Copy link
Contributor

maxhq commented Jan 3, 2017

Modifying /etc/sysctl.conf as done in flash_optimize.py leads to upgrade warnings and is hard to maintain.
The script should follow the official recommendations and create a separate file (e.g. /etc/sysctl.d/99-rockstor) which can easily be deleted and re-created on updates.
@schakrava schakrava added this to the Point Bonita milestone Mar 24, 2017
@schakrava
Copy link
Member

Thanks for reporting this @maxhq

@schakrava schakrava self-assigned this Aug 28, 2017
schakrava added a commit that referenced this issue Sep 17, 2017
@schakrava
Merge pull request #1819 from schakrava/1598_sysctl
c004ee4 
write to 99-rockstor.conf instead of sysctl.conf. Fixes #1598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schakrava schakrava

Labels
enhancement
Projects
None yet
Milestone
Point Bonita
Development

No branches or pull requests
2 participants
@schakrava @maxhq