Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Samba AD closing line #1548

Closed
MFlyer opened this issue Nov 28, 2016 · 0 comments
Closed

Wrong Samba AD closing line #1548

MFlyer opened this issue Nov 28, 2016 · 0 comments
Assignees
@MFlyer
Labels
bug
Milestone
Pinnacles

Comments

@MFlyer
Copy link
Member

MFlyer commented Nov 28, 2016

Ref to forum thread https://forum.rockstor.com/t/wrong-tagging-in-smb-conf/2418 by user g6094199:

There's a minor "bug":
Samba AD Configuration closing tag has "BEGIN" instead of "END"

This doesn't raise any error and/or unexpected behaviour, one line fix coming now
@MFlyer MFlyer mentioned this issue Nov 28, 2016
Merged
schakrava added a commit that referenced this issue Nov 30, 2016
@schakrava
Merge pull request #1549 from MFlyer/issue#1548_Samba_AD_Closing_tag
6a37d16 
Fixes #1548, closing tag now has END instead of BEGIN
@schakrava schakrava changed the title [Minor bug] Wrong Samba AD closing line Wrong Samba AD closing line Dec 13, 2016
@schakrava schakrava added the bug label Dec 13, 2016
@schakrava schakrava added this to the Pinnacles milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MFlyer MFlyer

Labels
bug
Projects
None yet
Milestone
Pinnacles
Development

No branches or pull requests
2 participants
@schakrava @MFlyer