Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

populate disk info for system disk #1116

Closed
phillxnet opened this issue Jan 23, 2016 · 2 comments
Closed

populate disk info for system disk #1116

phillxnet opened this issue Jan 23, 2016 · 2 comments

Comments

@phillxnet
Copy link
Member

The Model, Transport, Vendor entries on the Storage - Disks page for the system disk are always null; it would be nice to have these show the correct information.
@phillxnet
Copy link
Member Author

I am currently having a quick look at this issue.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 31, 2016
@phillxnet
add model, transport, vendor, and hctl to root partition info rocksto…
83cb349 
…r#1116

Collect these in the exact same way as we previously collected the
serial from the root device as not given by lsblk when examining the
root partition directly.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 31, 2016
@phillxnet
remove logging used in issue rockstor#1116
aea3525
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 31, 2016
@phillxnet
correct / improve comment on root_disk function rockstor#1116
1dabe4f 
added logging to prove return value
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 31, 2016
@phillxnet
remove root_disk logging line used in this issue rockstor#1116
6a93006
@phillxnet
Copy link
Member Author

The result of this patch set on the disks page is as follows:-
root_model_transport_info

ie we now have populated Model, Transport, and Vendor columns for our root / system device.

@phillxnet phillxnet mentioned this issue Jan 31, 2016
Merged
schakrava added a commit that referenced this issue Jan 31, 2016
@schakrava
Merge pull request #1140 from phillxnet/1116_populate_disk_info_for_s…
b694a3f 
…ystem_disk

populate disk info for system disk. Fixes #1116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phillxnet