-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update paperless-ngx.json #405
Conversation
I made a mistake in the volume part for paperless. I have fixed this. Should have no impact on usage and update as only the export and import shares were changed. Added PAPERLESS_SECRET_KEY, PAPERLESS_URL and PAPERLESS_CSRF_TRUSTED_ORIGINS which can all be left empty but are useful if a nginx or similar is in use.
This field can be left blank. to new env vars
Glad you found the volume issue, because our previous tests didn't really execute the functionality but only the installation success. So that change should be fine to go. On the additional fields though, we still have the same challenge that the environment fields are currently all mandatory with no way of setting them to optional. So, if at this time, we were to add these fields in, a user would have to maintain all of that info even if no public-facing implementation is planned. Related to this #2280. So for now, I recommend to split this PR, park the additional environment fields, and just push the immediate changes required. We can then revisit (likely after the next stable release) to see how this can be addressed. Of course, you're welcome to take a look yourself. |
remove the add env vars
I removed the env vars. So the volumes can be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. re-installation showed the mapped volumes working properly.
@BrokenOnedroid Thanks for the follow-up correction here. From: https://github.com/paperless-ngx/paperless-ngx/blob/dev/Dockerfile We have:
|
PRODUCTION published |
I made a mistake in the volume part for paperless. I have fixed this. Should have no impact on usage and update as only the export and import shares were changed. Added PAPERLESS_SECRET_KEY, PAPERLESS_URL and PAPERLESS_CSRF_TRUSTED_ORIGINS which can all be left empty but are useful if a nginx or similar is in use.