Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paperless-ngx.json #405

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

BrokenOnedroid
Copy link
Contributor

I made a mistake in the volume part for paperless. I have fixed this. Should have no impact on usage and update as only the export and import shares were changed. Added PAPERLESS_SECRET_KEY, PAPERLESS_URL and PAPERLESS_CSRF_TRUSTED_ORIGINS which can all be left empty but are useful if a nginx or similar is in use.

I made a mistake in the volume part for paperless. I have fixed this. Should have no impact on usage and update as only the export and import shares were changed. Added PAPERLESS_SECRET_KEY, PAPERLESS_URL and PAPERLESS_CSRF_TRUSTED_ORIGINS which can all be left empty but are useful if a nginx or similar is in use.
This field can be left blank. to new env vars
@Hooverdan96 Hooverdan96 added the needs review Test install, function, on / off behaviour, all links / info. label Dec 9, 2024
@Hooverdan96
Copy link
Member

Glad you found the volume issue, because our previous tests didn't really execute the functionality but only the installation success. So that change should be fine to go.

On the additional fields though, we still have the same challenge that the environment fields are currently all mandatory with no way of setting them to optional. So, if at this time, we were to add these fields in, a user would have to maintain all of that info even if no public-facing implementation is planned. Related to this #2280.

image

So for now, I recommend to split this PR, park the additional environment fields, and just push the immediate changes required. We can then revisit (likely after the next stable release) to see how this can be addressed. Of course, you're welcome to take a look yourself.

remove the add env vars
@BrokenOnedroid
Copy link
Contributor Author

I removed the env vars. So the volumes can be fixed.

@Hooverdan96 Hooverdan96 removed the needs review Test install, function, on / off behaviour, all links / info. label Dec 10, 2024
Copy link
Member

@Hooverdan96 Hooverdan96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. re-installation showed the mapped volumes working properly.

@phillxnet phillxnet merged commit fc8f11a into rockstor:master Dec 11, 2024
@phillxnet
Copy link
Member

@BrokenOnedroid Thanks for the follow-up correction here.

From: https://github.com/paperless-ngx/paperless-ngx/blob/dev/Dockerfile

We have:

VOLUME ["/usr/src/paperless/data", \
        "/usr/src/paperless/media", \
        "/usr/src/paperless/consume", \
        "/usr/src/paperless/export"]

@phillxnet
Copy link
Member

PRODUCTION published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants