fix(newsigv4): persists the watch event beyond the first instance #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inotify works on watching specific inodes, the current implementation proved brittle if the process mutating the watched file does so by created a new file and then renaming. This action causes the file under the same path to change contents and exist with a new inode. Instead we watch the parent directory and filter incoming events by filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inotify works on watching specific inodes, the current
implementation proved brittle if the process mutating
the watched file does so by created a new file and then
renaming. This action causes the file under the same
path to change contents and exist with a new inode.
Instead we watch the parent directory and filter incoming
events by filename.