Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use poetry lock --check feature from alpha #357

Merged
merged 11 commits into from
Jun 1, 2022

Conversation

RoiGlinik
Copy link
Contributor

Simple action to test the lock file. Uses an alpha version of poetry.
We will have to update using:
poetry self update --preview

Check is not aligned with older versions.

@RoiGlinik RoiGlinik requested a review from aantn May 29, 2022 11:16
@aantn
Copy link
Collaborator

aantn commented May 29, 2022

@RoiGlinik when you say "we will have to update" do you mean us developers on our local machines?

@RoiGlinik
Copy link
Contributor Author

@aantn yea, for running the check command and the sync command ourselfs.
Also i seem to have a problem with the test

@aantn
Copy link
Collaborator

aantn commented May 29, 2022

@RoiGlinik is the error because they're running an old version of poetry and not installing stuff correctly? Something else?

@RoiGlinik
Copy link
Contributor Author

@aantn Yea i had to update it at the docker file and the test action as well . now they all use the new version

@aantn
Copy link
Collaborator

aantn commented Jun 1, 2022

Looks good to me, just make sure you document and announce to everyone that they need to update poetry.

  1. I would do a search on the whole project for references to "poetry" and see if we need to update any docs, etc
  2. Send a message to everyone in the slack community (in the #general channel) with the exact command they'll need to run to avoid breaking their local setup

@RoiGlinik RoiGlinik merged commit 2e0e714 into master Jun 1, 2022
@RoiGlinik RoiGlinik deleted the poetry-lock-check-git-action branch June 1, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants